-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Describe the bug
v0.14 scheduled removals from the deprecation tracker were forgot and they still exist in latest version (v0.14.0). This makes our tests fail due to those fail_on_pvlib_version decorators.
To Reproduce
See #2396.
Expected behavior
For these claims to have been enforced.
Screenshots
N/A
Versions:
pvlib.__version__: v0.14.0
Additional context
Originally reported by @aman-coder03 in #2646 (comment)
Extract of test fails due to non-removed deprecations (from #2646 logs)
2026-01-18T10:03:06.2500349Z FAILED tests/test_irradiance.py::test_dirindex_ghi_clearsky_deprecation - Failed: the tested function is scheduled to be removed in 0.14
2026-01-18T10:03:06.2501209Z FAILED tests/test_irradiance.py::test_dirindex_dni_clearsky_deprecation - Failed: the tested function is scheduled to be removed in 0.14
2026-01-18T10:03:06.2502039Z FAILED tests/test_irradiance.py::test_dni_dni_clearsky_deprecation - Failed: the tested function is scheduled to be removed in 0.14
2026-01-18T10:03:06.2502900Z FAILED tests/test_irradiance.py::test_clearsky_index_clearsky_ghi_deprecation - Failed: the tested function is scheduled to be removed in 0.14
Proposals
We already scheduled this breaking change and most user-base should have had the time to read the whatsnews, see run-time warnings and update their code. (a) I suggest we remove these functions for next patch version (v0.14.1) and as soon as possible to have uncluttered pytest failures.
(b) We can also defer to v0.15.0 since they still count as breaking changes. A PR updating test failures and messages is still suggested for successful CI.
@pvlib/pvlib-maintainer please leave your thoughts. Let's have a clear action to take by February 6th (two weeks) or earlier.