From 8cb2f51b88aaeae47d5179bed665a95d153053d1 Mon Sep 17 00:00:00 2001 From: David Bennett Date: Mon, 26 Jan 2026 14:13:59 -0800 Subject: [PATCH 1/3] Remove experimental feature requirement for source edit --- src/AppInstallerCLICore/Commands/SourceCommand.cpp | 1 - src/AppInstallerCLICore/Commands/SourceCommand.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/AppInstallerCLICore/Commands/SourceCommand.cpp b/src/AppInstallerCLICore/Commands/SourceCommand.cpp index 968873b757..bf7a2b1a12 100644 --- a/src/AppInstallerCLICore/Commands/SourceCommand.cpp +++ b/src/AppInstallerCLICore/Commands/SourceCommand.cpp @@ -359,7 +359,6 @@ namespace AppInstaller::CLI void SourceEditCommand::ExecuteInternal(Context& context) const { context << - Workflow::EnsureFeatureEnabled(Settings::ExperimentalFeature::Feature::SourceEdit) << Workflow::EnsureRunningAsAdmin << Workflow::GetSourceListWithFilter << Workflow::EditSources; diff --git a/src/AppInstallerCLICore/Commands/SourceCommand.h b/src/AppInstallerCLICore/Commands/SourceCommand.h index 2e52ccf578..deda3f03a6 100644 --- a/src/AppInstallerCLICore/Commands/SourceCommand.h +++ b/src/AppInstallerCLICore/Commands/SourceCommand.h @@ -124,7 +124,7 @@ namespace AppInstaller::CLI struct SourceEditCommand final : public Command { - SourceEditCommand(std::string_view parent) : Command("edit", { "config", "set" }, parent, Settings::ExperimentalFeature::Feature::SourceEdit) {} + SourceEditCommand(std::string_view parent) : Command("edit", { "config", "set" }, parent) {} std::vector GetArguments() const override; From 4dfac20a7d17986fb3d8d742a03128d83a38a231 Mon Sep 17 00:00:00 2001 From: David Bennett Date: Mon, 26 Jan 2026 14:17:10 -0800 Subject: [PATCH 2/3] Update release notes --- doc/ReleaseNotes.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/doc/ReleaseNotes.md b/doc/ReleaseNotes.md index da8eaeb121..1acd66d25c 100644 --- a/doc/ReleaseNotes.md +++ b/doc/ReleaseNotes.md @@ -3,15 +3,9 @@ * Bumped the winget version to 1.28 to match the package version. * Additional [options for limiting the size of log files](https://github.com/microsoft/winget-cli/blob/master/doc/Settings.md#file). -# Experimental Feature: 'sourceEdit' +# Feature: 'source edit' New feature that adds an 'edit' subcommand to the 'source' command. This can be used to set an explicit source to be implicit and vice-versa. For example, with this feature you can make the 'winget-font' source an implicit source instead of explicit source. -To enable this feature, add the 'sourceEdit' experimental feature to your settings. -``` -"experimentalFeatures": { - "sourceEdit": true -}, -``` To use the feature, try `winget source edit winget-font` to set the Explicit state to the default. ## Bug Fixes From 1d88ae28954207e1eb25951dca7cf64616b1a14c Mon Sep 17 00:00:00 2001 From: David Bennett Date: Tue, 27 Jan 2026 10:31:25 -0800 Subject: [PATCH 3/3] Remove experimental feature entirely --- doc/Settings.md | 10 ---------- schemas/JSON/settings/settings.schema.0.2.json | 5 ----- src/AppInstallerCommonCore/ExperimentalFeature.cpp | 5 ----- .../Public/winget/ExperimentalFeature.h | 1 - .../Public/winget/UserSettings.h | 2 -- src/AppInstallerCommonCore/UserSettings.cpp | 1 - 6 files changed, 24 deletions(-) diff --git a/doc/Settings.md b/doc/Settings.md index 2beeced86c..139a6079e4 100644 --- a/doc/Settings.md +++ b/doc/Settings.md @@ -394,16 +394,6 @@ This feature enables support for fonts via `winget settings`. The `winget font l }, ``` -### sourceEdit - -This feature enables support for additional source command improvements via `winget settings`. The `winget source edit` command will become available with this feature. - -```json - "experimentalFeatures": { - "sourceEdit": true - }, -``` - ### listDetails This feature enables support for displaying detailed output from the `list` command. Rather than a table view of the results, when the `--details` option is provided diff --git a/schemas/JSON/settings/settings.schema.0.2.json b/schemas/JSON/settings/settings.schema.0.2.json index c8eb465cbf..43b26ed2a2 100644 --- a/schemas/JSON/settings/settings.schema.0.2.json +++ b/schemas/JSON/settings/settings.schema.0.2.json @@ -333,11 +333,6 @@ "description": "Enable detailed output option for list command", "type": "boolean", "default": false - }, - "sourceEdit": { - "description": "Enable source edit command", - "type": "boolean", - "default": false } } } diff --git a/src/AppInstallerCommonCore/ExperimentalFeature.cpp b/src/AppInstallerCommonCore/ExperimentalFeature.cpp index c38f37e4de..09bbb0f661 100644 --- a/src/AppInstallerCommonCore/ExperimentalFeature.cpp +++ b/src/AppInstallerCommonCore/ExperimentalFeature.cpp @@ -46,8 +46,6 @@ namespace AppInstaller::Settings return userSettings.Get(); case ExperimentalFeature::Feature::ListDetails: return userSettings.Get(); - case ExperimentalFeature::Feature::SourceEdit: - return userSettings.Get(); default: THROW_HR(E_UNEXPECTED); } @@ -83,9 +81,6 @@ namespace AppInstaller::Settings return ExperimentalFeature{ "Font", "fonts", "https://aka.ms/winget-settings", Feature::Font }; case Feature::ListDetails: return ExperimentalFeature{ "List Details", "listDetails", "https://aka.ms/winget-settings", Feature::ListDetails }; - case Feature::SourceEdit: - return ExperimentalFeature{ "Source Editing", "sourceEdit", "https://aka.ms/winget-settings", Feature::SourceEdit }; - default: THROW_HR(E_UNEXPECTED); } diff --git a/src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h b/src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h index 70cd889d63..33571c48aa 100644 --- a/src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h +++ b/src/AppInstallerCommonCore/Public/winget/ExperimentalFeature.h @@ -26,7 +26,6 @@ namespace AppInstaller::Settings Resume = 0x2, Font = 0x4, ListDetails = 0x8, - SourceEdit = 0x10, Max, // This MUST always be after all experimental features // Features listed after Max will not be shown with the features command diff --git a/src/AppInstallerCommonCore/Public/winget/UserSettings.h b/src/AppInstallerCommonCore/Public/winget/UserSettings.h index bf3c03f8cd..e5e12c0b61 100644 --- a/src/AppInstallerCommonCore/Public/winget/UserSettings.h +++ b/src/AppInstallerCommonCore/Public/winget/UserSettings.h @@ -77,7 +77,6 @@ namespace AppInstaller::Settings EFResume, EFFonts, EFListDetails, - EFSourceEdit, // Telemetry TelemetryDisable, // Install behavior @@ -166,7 +165,6 @@ namespace AppInstaller::Settings SETTINGMAPPING_SPECIALIZATION(Setting::EFResume, bool, bool, false, ".experimentalFeatures.resume"sv); SETTINGMAPPING_SPECIALIZATION(Setting::EFFonts, bool, bool, false, ".experimentalFeatures.fonts"sv); SETTINGMAPPING_SPECIALIZATION(Setting::EFListDetails, bool, bool, false, ".experimentalFeatures.listDetails"sv); - SETTINGMAPPING_SPECIALIZATION(Setting::EFSourceEdit, bool, bool, false, ".experimentalFeatures.sourceEdit"sv); // Telemetry SETTINGMAPPING_SPECIALIZATION(Setting::TelemetryDisable, bool, bool, false, ".telemetry.disable"sv); // Install behavior diff --git a/src/AppInstallerCommonCore/UserSettings.cpp b/src/AppInstallerCommonCore/UserSettings.cpp index d5147076ae..b0f87fd625 100644 --- a/src/AppInstallerCommonCore/UserSettings.cpp +++ b/src/AppInstallerCommonCore/UserSettings.cpp @@ -268,7 +268,6 @@ namespace AppInstaller::Settings WINGET_VALIDATE_PASS_THROUGH(EFResume) WINGET_VALIDATE_PASS_THROUGH(EFFonts) WINGET_VALIDATE_PASS_THROUGH(EFListDetails) - WINGET_VALIDATE_PASS_THROUGH(EFSourceEdit) WINGET_VALIDATE_PASS_THROUGH(AnonymizePathForDisplay) WINGET_VALIDATE_PASS_THROUGH(TelemetryDisable) WINGET_VALIDATE_PASS_THROUGH(InteractivityDisable)