Skip to content

docs/config.json: score_multiplier minimum constraint weaker than runtime model (0 vs gt=0) #1333

@coderabbitai

Description

@coderabbitai

Summary

The JSON schema for score_multiplier in docs/config.json documents "minimum": 0, which allows zero as a valid value. However, the runtime model in src/models/config.py enforces gt=0 (strictly greater than zero), meaning a value of 0 will be rejected at runtime.

This mismatch means generated clients and API documentation will indicate 0 is a valid value, while the service will reject it.

Proposed Fix

Add "exclusiveMinimum": true to the score_multiplier schema entry in docs/config.json:

           "score_multiplier": {
             "default": 1.0,
             "description": "Multiplier applied to relevance scores from this vector store. Used to weight results when querying multiple knowledge sources. Values > 1 boost this store's results; values < 1 reduce them.",
             "minimum": 0,
+            "exclusiveMinimum": true,
             "title": "Score multiplier",
             "type": "number"
           }

References

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions