OCCM HelmChart - Daemonset checksum does not contemplate .Values.cloudConfigContents #3030
Description
/kind bug
What happened:
OCCM daemonset sets up a checksum/config annotation with the hash of the config produced by {{ include "cloudConfig" . }} but it does not take into account the possibility to set {{ .Values.cloudConfigContents }} (and the secret does).
This causes the daemonset to not change when the CloudConfig provided by the values changes (e.g. user password), making the pods keep the old/invalid configuration.
What you expected to happen:
The daemonset rolls out when the CloudConfig from Values changes.
How to reproduce it:
Install the helm chart by providing cloudConfigContents in the values. Then upgrade the release with a change in that same cloudConfigContents. Observe that DaemonSet pods were not recreated.
Anything else we need to know?:
Environment:
- openstack-cloud-controller-manager(or other related binary) version:
- OpenStack version:
- Others: