Build failure in write-fonts caused by incompatible change in read-fonts 0.35.1

[ogoffart]

We got this error on our CI:

error[E0277]: the trait bound `u16: from_obj::FromObjRef<types::BigEndian<types::NameId>>` is not satisfied
   --> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/write-fonts-0.43.0/src/tables/../../generated/generated_cpal.rs:126:62
    |
126 |             palette_labels_array: obj.palette_labels_array().to_owned_obj(offset_data),
    |                                                              ^^^^^^^^^^^^ the trait `from_obj::FromObjRef<types::BigEndian<types::NameId>>` is not implemented for `u16`
    |
    = help: the trait `from_obj::FromObjRef<u8>` is implemented for `u8`
note: required for `Vec<u16>` to implement `from_obj::FromObjRef<&[types::BigEndian<types::NameId>]>`
   --> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/write-fonts-0.43.0/src/from_obj.rs:90:12
    |
 90 | impl<T, U> FromObjRef<&[U]> for Vec<T>
    |            ^^^^^^^^^^^^^^^^     ^^^^^^
 91 | where
 92 |     T: FromObjRef<U>,
    |        ------------- unsatisfied trait bound introduced here
    = note: 1 redundant requirement hidden
    = note: required for `offsets::NullableOffsetMarker<Vec<u16>, 4>` to implement `FromObjRef<Option<Result<&[BigEndian<NameId>], ReadError>>>`
note: required for `Option<Result<&[types::BigEndian<types::NameId>], read_fonts::ReadError>>` to implement `from_obj::ToOwnedObj<offsets::NullableOffsetMarker<Vec<u16>, 4>>`
   --> /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/write-fonts-0.43.0/src/from_obj.rs:55:12
    |
 55 | impl<U, T> ToOwnedObj<U> for T
    |            ^^^^^^^^^^^^^     ^
 56 | where
 57 |     U: FromObjRef<T>,
    |        ------------- unsatisfied trait bound introduced here
    = note: the full name for the type has been written to '/Users/runner/work/slint/slint/target/debug/deps/write_fonts-73860f28664ddb3d.long-type-2410230489728484686.txt'
    = note: consider using `--verbose` to print the full type name to the console

Presumably, this is caused by this change in the recent read-fonts 0.35.1 that changes the signature of palette_labels_array
707ebc8#diff-a69acb71aa0ad51fbd7755c2e95b280a00c1bc8c20507a684f72729e832daf1cR200

[ronnybremer]

Would it be possible to release this as a fix? Some CI builds are failing, as they pull in the latest release 0.35.1. Thank you!

[dfrg]

Seems like this release caused quite a few problems. I’ll publish a fix today.

[dfrg]

I released read-fonts 0.36.0, write-fonts 0.44.0 and skrifa 0.39.0. Also yanked read-fonts 0.35.1 and skrifa 0.38.0 which exposed breaking changes without the required version bumps.

Hopefully this fixes all issues. Thanks for the report!

[ronnybremer]

I can confirm, that the CI is working again. Thank you @dfrg!