feat: add defer linter

Author: rawen17

go.mod

@@ -9,6 +9,7 @@ require (
 	github.com/Antonboom/nilnil v0.1.1
 	github.com/BurntSushi/toml v1.2.0
 	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
+	github.com/GaijinEntertainment/go-defer v1.2.0
 	github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
 	github.com/OpenPeeDeeP/depguard v1.1.1
 	github.com/alexkohler/prealloc v1.0.0

go.sum

@@ -0,0 +1,22 @@
+package golinters
+
+import (
+	"github.com/GaijinEntertainment/go-defer/pkg/analyzer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewDefer() *goanalysis.Linter {
+	a, err := analyzer.NewAnalyzer()
+	if err != nil {
+		linterLogger.Fatalf("defer configuration: %v", err)
+	}
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/defer.go

@@ -404,6 +404,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/GaijinEntertainment/go-exhaustruct"),
 
+		linter.NewConfig(golinters.NewDefer()).
+			WithSince("v1.51.0").
+			WithPresets(linter.PresetStyle).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/GaijinEntertainment/go-defer"),
+
 		linter.NewConfig(golinters.NewExportLoopRef()).
 			WithSince("v1.28.0").
 			WithPresets(linter.PresetBugs).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,40 @@
+//golangcitest:args -Edefer
+package testdata
+
+func funcReturnsInt() int {
+	return 1
+}
+
+func funcReturnsFunc() func() {
+	return func() {
+	}
+}
+
+func funcReturnsErrAndFunc() (error, func()) {
+	return nil, func() {
+	}
+}
+
+func funcDeferReturnGoodValue() {
+	defer funcReturnsInt()
+}
+
+func funcDeferReturnFunc() {
+	defer funcReturnsFunc() // want "deferred call should not return a function"
+}
+
+func funcDeferReturnErrAndFunc() {
+	defer funcReturnsErrAndFunc() // want "deferred call should not return a function"
+}
+
+func funcDeferAnonymousReturnFunc() {
+	defer func() func() { // want "deferred call should not return a function"
+		return func() {}
+	}()
+}
+
+func funcDeferAnonymousReturnErrAndFunc() {
+	defer func() (error, func()) { // want "deferred call should not return a function"
+		return nil, func() {}
+	}()
+}