diff --git a/exercises/concept/amusement-park-improvements/.meta/exemplar.rb b/exercises/concept/amusement-park-improvements/.meta/exemplar.rb index 3564509020..dd677df82c 100644 --- a/exercises/concept/amusement-park-improvements/.meta/exemplar.rb +++ b/exercises/concept/amusement-park-improvements/.meta/exemplar.rb @@ -7,11 +7,11 @@ def has_pass? !!@pass_id end - def issue_pass!(pass_id) + def issue_pass(pass_id) @pass_id = pass_id end - def revoke_pass! + def revoke_pass @pass_id = nil end diff --git a/exercises/concept/amusement-park-improvements/attendee.rb b/exercises/concept/amusement-park-improvements/attendee.rb index f8e09bb63c..f9da8688e3 100644 --- a/exercises/concept/amusement-park-improvements/attendee.rb +++ b/exercises/concept/amusement-park-improvements/attendee.rb @@ -3,11 +3,11 @@ def initialize(height) @height = height end - def issue_pass!(pass_id) + def issue_pass(pass_id) @pass_id = pass_id end - def revoke_pass! + def revoke_pass @pass_id = nil end diff --git a/exercises/concept/amusement-park-improvements/attendee_test.rb b/exercises/concept/amusement-park-improvements/attendee_test.rb index e345302785..a90dccbf8b 100644 --- a/exercises/concept/amusement-park-improvements/attendee_test.rb +++ b/exercises/concept/amusement-park-improvements/attendee_test.rb @@ -8,14 +8,14 @@ def test_new_instance_doesnt_have_pass def test_when_issued_pass attendee = Attendee.new(100) - attendee.issue_pass!(1) + attendee.issue_pass(1) assert attendee.has_pass? end def test_when_revoked_doesnt_have_pass attendee = Attendee.new(100) - attendee.issue_pass!(1) - attendee.revoke_pass! + attendee.issue_pass(1) + attendee.revoke_pass refute attendee.has_pass? end @@ -37,13 +37,13 @@ def test_fits_ride_but_no_pass def test_fits_ride_and_pass attendee = Attendee.new(100) - attendee.issue_pass!(1) + attendee.issue_pass(1) assert attendee.allowed_to_ride?(100) end def test_does_not_fit_ride_and_pass attendee = Attendee.new(100) - attendee.issue_pass!(1) + attendee.issue_pass(1) refute attendee.allowed_to_ride?(120) end end diff --git a/exercises/concept/amusement-park/.meta/exemplar.rb b/exercises/concept/amusement-park/.meta/exemplar.rb index 49b0af1aec..62fc5a80b1 100644 --- a/exercises/concept/amusement-park/.meta/exemplar.rb +++ b/exercises/concept/amusement-park/.meta/exemplar.rb @@ -11,11 +11,11 @@ def pass_id @pass_id end - def issue_pass!(pass_id) + def issue_pass(pass_id) @pass_id = pass_id end - def revoke_pass! + def revoke_pass @pass_id = nil end end diff --git a/exercises/concept/amusement-park/attendee.rb b/exercises/concept/amusement-park/attendee.rb index add06a6334..b79995046b 100644 --- a/exercises/concept/amusement-park/attendee.rb +++ b/exercises/concept/amusement-park/attendee.rb @@ -11,11 +11,11 @@ def pass_id raise 'Implement the Attendee#pass_id method' end - def issue_pass!(pass_id) - raise 'Implement the Attendee#issue_pass! method' + def issue_pass(pass_id) + raise 'Implement the Attendee#issue_pass method' end - def revoke_pass! - raise 'Implement the Attendee#revoke_pass! method' + def revoke_pass + raise 'Implement the Attendee#revoke_pass method' end end diff --git a/exercises/concept/amusement-park/attendee_test.rb b/exercises/concept/amusement-park/attendee_test.rb index 61d411d558..bff9409ade 100644 --- a/exercises/concept/amusement-park/attendee_test.rb +++ b/exercises/concept/amusement-park/attendee_test.rb @@ -22,7 +22,7 @@ def test_issue_pass attendee = Attendee.new(height) pass_id = 1 - attendee.issue_pass!(pass_id) + attendee.issue_pass(pass_id) assert_equal pass_id, attendee.pass_id end @@ -31,8 +31,8 @@ def test_has_pass_after_revoked height = 100 attendee = Attendee.new(height) pass_id = 1 - attendee.issue_pass!(pass_id) - attendee.revoke_pass! + attendee.issue_pass(pass_id) + attendee.revoke_pass refute attendee.pass_id end end diff --git a/exercises/concept/moviegoer/.meta/exemplar.rb b/exercises/concept/moviegoer/.meta/exemplar.rb index ed8aa8af6b..5fd84fd987 100644 --- a/exercises/concept/moviegoer/.meta/exemplar.rb +++ b/exercises/concept/moviegoer/.meta/exemplar.rb @@ -17,7 +17,7 @@ def watch_scary_movie? age >= 18 end - def claim_free_popcorn! + def claim_free_popcorn raise NotMovieClubMemberError unless member "🍿" diff --git a/exercises/concept/moviegoer/moviegoer.rb b/exercises/concept/moviegoer/moviegoer.rb index 1fd01c6da8..e63f940cab 100644 --- a/exercises/concept/moviegoer/moviegoer.rb +++ b/exercises/concept/moviegoer/moviegoer.rb @@ -17,7 +17,7 @@ def watch_scary_movie? end # Popcorn is 🍿 - def claim_free_popcorn! + def claim_free_popcorn raise 'Please implement the Moviegoer#claim_free_popcorn method' end end diff --git a/exercises/concept/moviegoer/moviegoer_test.rb b/exercises/concept/moviegoer/moviegoer_test.rb index c31a3e4641..caabce2df5 100644 --- a/exercises/concept/moviegoer/moviegoer_test.rb +++ b/exercises/concept/moviegoer/moviegoer_test.rb @@ -19,12 +19,12 @@ def test_kids_cant_see_the_scary_movie end def test_members_get_free_popcorn - assert_equal "🍿", Moviegoer.new(25, member: true).claim_free_popcorn! + assert_equal "🍿", Moviegoer.new(25, member: true).claim_free_popcorn end def test_regular_moviegoers_dont_get_free_popcorn assert_raises NotMovieClubMemberError do - Moviegoer.new(25, member: false).claim_free_popcorn! + Moviegoer.new(25, member: false).claim_free_popcorn end end end diff --git a/exercises/practice/gilded-rose/.meta/example.rb b/exercises/practice/gilded-rose/.meta/example.rb index 4a3e936b45..225c492536 100644 --- a/exercises/practice/gilded-rose/.meta/example.rb +++ b/exercises/practice/gilded-rose/.meta/example.rb @@ -8,22 +8,22 @@ def initialize(name:, sell_in:, quality:) def conjured? = @conjured - def update! - update_quality! + def update + update_quality @quality = 0 if quality < 0 @quality = 0 if conjured? && sell_in <= 0 @quality = max_quality if quality > max_quality - update_sell_in! + update_sell_in end private def max_quality = 50 - def update_quality! = raise NotImplementedError + def update_quality = raise NotImplementedError - def update_sell_in! = @sell_in -= 1 + def update_sell_in = @sell_in -= 1 end class NormalItem < AbstractItem @@ -31,7 +31,7 @@ def self.name_regex = /.+/ # Should be checked last, after other item types. private - def update_quality! + def update_quality quality_change = -1 quality_change -= 1 if sell_in <= 0 quality_change *= 2 if conjured? @@ -45,7 +45,7 @@ def self.name_regex = /Aged Brie/ private - def update_quality! + def update_quality quality_change = 1 quality_change += 1 if sell_in <= 0 @@ -60,10 +60,10 @@ def self.name_regex = /Sulfuras, Hand of Ragnaros/ def max_quality = 80 - def update_quality! + def update_quality end - def update_sell_in! + def update_sell_in @sell_in -= 1 if conjured? end end @@ -73,7 +73,7 @@ def self.name_regex = /Backstage passes to a TAFKAL80ETC concert/i private - def update_quality! + def update_quality @quality = 0 and return if sell_in <= 0 quality_change = 1 @@ -103,9 +103,9 @@ def initialize(items) @items = items end - def update! + def update @items.each do |item| - item.update! + item.update end end end diff --git a/exercises/practice/gilded-rose/gilded_rose.rb b/exercises/practice/gilded-rose/gilded_rose.rb index 45cbf099aa..9f255847dc 100644 --- a/exercises/practice/gilded-rose/gilded_rose.rb +++ b/exercises/practice/gilded-rose/gilded_rose.rb @@ -5,7 +5,7 @@ def initialize(items) @items = items end - def update! + def update @items.each do |item| if item.name != "Aged Brie" && item.name != "Backstage passes to a TAFKAL80ETC concert" if item.quality > 0 diff --git a/exercises/practice/gilded-rose/gilded_rose_test.rb b/exercises/practice/gilded-rose/gilded_rose_test.rb index 566361958d..4dcba9300b 100644 --- a/exercises/practice/gilded-rose/gilded_rose_test.rb +++ b/exercises/practice/gilded-rose/gilded_rose_test.rb @@ -4,7 +4,7 @@ class GildedRoseTest < Minitest::Test def update_with(sell_in:, quality:, name:, sell_in_change: -1, quality_change: -1) item = Item.new(name:, sell_in:, quality:) - GildedRose.new([item]).update! + GildedRose.new([item]).update assert_equal sell_in + sell_in_change, item.sell_in assert_equal quality + quality_change, item.quality @@ -239,7 +239,7 @@ def test_multiple_items normal_item = Item.new(name: "some item", sell_in: 1, quality: 10) aged_brie = Item.new(name: "Aged Brie", sell_in: -1, quality: 10) - GildedRose.new([normal_item, aged_brie]).update! + GildedRose.new([normal_item, aged_brie]).update assert_equal 9, normal_item.quality assert_equal 0, normal_item.sell_in diff --git a/exercises/practice/simple-linked-list/.meta/example.rb b/exercises/practice/simple-linked-list/.meta/example.rb index 5c3af10b88..11e81badd2 100644 --- a/exercises/practice/simple-linked-list/.meta/example.rb +++ b/exercises/practice/simple-linked-list/.meta/example.rb @@ -34,7 +34,7 @@ def pop element end - def reverse! + def reverse previous = nil pointer = @head while pointer diff --git a/exercises/practice/simple-linked-list/simple_linked_list_test.rb b/exercises/practice/simple-linked-list/simple_linked_list_test.rb index eb07b74895..65eb118594 100644 --- a/exercises/practice/simple-linked-list/simple_linked_list_test.rb +++ b/exercises/practice/simple-linked-list/simple_linked_list_test.rb @@ -103,7 +103,7 @@ def test_list_from_array_still_acts_as_lifo assert_equal 3, element.datum end - def test_list_in_place_reverse! + def test_list_in_place_reverse skip first = Element.new(1) second = Element.new(2) @@ -111,7 +111,7 @@ def test_list_in_place_reverse! list = SimpleLinkedList.new list.push(first).push(second).push(third) - assert_equal [1, 2, 3], list.reverse!.to_a + assert_equal [1, 2, 3], list.reverse.to_a end def test_list_in_place_reverse_are_the_same_elements @@ -121,7 +121,7 @@ def test_list_in_place_reverse_are_the_same_elements list = SimpleLinkedList.new list.push(first).push(second) - list.reverse! + list.reverse assert_equal first, list.pop assert_equal second, list.pop @@ -130,7 +130,7 @@ def test_list_in_place_reverse_are_the_same_elements def test_list_reverse_empty_list skip list = SimpleLinkedList.new - assert_equal list, list.reverse! + assert_equal list, list.reverse end def test_works_for_1_through_10