DuckDBPyType.children should return a tuple, not a list #349
OutSquareCapital
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Unless mutability is needed internally, this would improve Datatypes on multiples areas, and would be a first step to a more in-depth future improvement of datatypes API.
I have already code that exist for this and would be happy to make a PR for the static typing side.
Also side note:
would be nice if
JSONandBIGINTcould be exposed as constant just like the other "simple" types.https://github.com/OutSquareCapital/pql/blob/7a9f8ec00c55cd8d8c0eadd7dfb85ad6d1aa1dcc/src/pql/sql/_datatypes.py#L63
Beta Was this translation helpful? Give feedback.
All reactions