Skip to content

[Bug]: CDF - Rendering Adds ?cdv=nn if using External Path w/o Protocol for DnnXxIncludes -- v10.02.00 RC2 #6855

@jeremy-farrance

Description

@jeremy-farrance

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

See code below for details and to reproduce using Aperture default.aspx

Test 5 - Add Tailwind Plus Elements as type=module JS Include

  • Issue 5A: an external URL should not be getting the ?cdv=NN appended
  • note that the issue does NOT happen if you include the protocol (https:) in the FilePath

Note: already reported the unwanted type"text/javascript" attribute in Issue #6851

Steps to reproduce?

In a new deploy or DNN v10.02.00 RC2, Insert everything below into ~/Portals/_default/Skins/Aperture/default.aspx at line 4.

<%-- copy+paste this into Aperture default.ascx at line 4 to test --%>

<%-- Test 5 - Add Tailwind Plus Elements as type=module JS Include

  - Issue 5A: an external URL should not be getting the ?cdv=NN appended
  - note that the issue does NOT happen if you include the protocol (https:) in the FilePath

Note: already reported the double type attribute in Issue #6851 
--%>
<dnn:DnnJsInclude
  FilePath="https://cdn.jsdelivr.net/npm/@tailwindplus/elements@1"
  HtmlAttributesAsString="type:module"
  ForceProvider="DnnPageHeaderProvider"
  Priority="5"
  runat="server"
/>

<%-- 
Desired outcome in <head>:
<script src="//cdn.jsdelivr.net/npm/@tailwindplus/elements@1" type="module"></script>

Results in DNN v10.02.00 RC2 (without https:):
<script src="//cdn.jsdelivr.net/npm/@tailwindplus/elements@1?cdv=50" type="text/javascript" type="module"></script>
                                                            ^^^^^^^   
Results in DNN v10.02.00 RC2 (with https:):
<script src="https://cdn.jsdelivr.net/npm/@tailwindplus/elements@1" type="text/javascript" type="module"></script>

Results in DNN v10.01.02:
<script src="https://cdn.jsdelivr.net/npm/@tailwindplus/elements@1?cdv=50" type="module"></script>
--%>


<%-- end of CDF tests, Aperture Skin below --%>

Current Behavior

Covered aboved.

Expected Behavior

Covered aboved.

Relevant log output

n/a

Anything else?

No response

Affected Versions

10.02.00 RC2 or current development branch (unreleased)

What browsers are you seeing the problem on?

Chrome

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions