Skip to content

question/possible bug with train-test split in TriangleSplit (v.0.2.2) #9

@marosre97

Description

@marosre97

Seems to me that splitting creates triangles for train and test.
Looking at the reference document, I assumed that this is not the expected behavior...

...
yield (
                indices[X.triangle.valuation <= valuation_dates[test_start]], # should be '<' instead of '<=' so that training set consists of k-dim triangle; for testing the first next diagonal is concatenated
                indices[X.triangle.valuation <= valuation_dates[test_start]],
            )

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions