GH-48888: [Ruby] Add support for writing boolean array#48889
Merged
kou merged 1 commit intoapache:mainfrom Jan 19, 2026
Merged
Conversation
|
|
hiroyuki-sato
approved these changes
Jan 19, 2026
Collaborator
hiroyuki-sato
left a comment
There was a problem hiding this comment.
+1
LD_LIBRARY_PATH=/tmp/local/lib GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 rake test
cd /path/to/arrow/ruby/red-arrow-format
/path/to/.rbenv/versions/3.4.7/bin/ruby test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:40: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 1.543011232 seconds.
-----------------------------------------------------------------------------------------------------------------------------
108 tests, 108 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-----------------------------------------------------------------------------------------------------------------------------
69.99 tests/s, 69.99 assertions/s
cd -
| module BufferAlignable | ||
| include FlatBuffers::Alignable | ||
|
|
||
| BUFFER_ALIGNMENT_SIZE = 64 |
Collaborator
There was a problem hiding this comment.
Nit: What do you think about adding units like BUFFER_ALIGNMENT_BYTES or BUFFER_ALIGNMENT_BITS? (I didn't know the unit)
Member
Author
There was a problem hiding this comment.
Hmm. I don't think that we need it (at least for now). In general, alignment unit is bytes.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 97c656b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
It's a primitive array.
What changes are included in this PR?
ArrowFormat::BooleanType#to_flat_buffersAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.