From ba25178345210d2abe0ace68d6654261d65953a6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=E1=BA=A7n=20Trung=20Ki=C3=AAn?= <poverty1990@gmail.com>
Date: Thu, 27 Nov 2025 17:18:46 +0700
Subject: [PATCH 1/2] feat(tests): add toggleAllRowsSelected tests to respect
 row selection rules

---
 .../table-core/src/features/RowSelection.ts   |  3 +
 .../table-core/tests/RowSelection.test.ts     | 70 +++++++++++++++++++
 2 files changed, 73 insertions(+)

diff --git a/packages/table-core/src/features/RowSelection.ts b/packages/table-core/src/features/RowSelection.ts
index 90166823aa..a7d127ab7e 100644
--- a/packages/table-core/src/features/RowSelection.ts
+++ b/packages/table-core/src/features/RowSelection.ts
@@ -245,6 +245,9 @@ export const RowSelection: TableFeature = {
           })
         } else {
           preGroupedFlatRows.forEach(row => {
+            if (!row.getCanSelect()) {
+              return
+            }
             delete rowSelection[row.id]
           })
         }
diff --git a/packages/table-core/tests/RowSelection.test.ts b/packages/table-core/tests/RowSelection.test.ts
index 38bdfb7dcb..8f970171b8 100644
--- a/packages/table-core/tests/RowSelection.test.ts
+++ b/packages/table-core/tests/RowSelection.test.ts
@@ -320,4 +320,74 @@ describe('RowSelection', () => {
       expect(result).toEqual('some')
     })
   })
+
+  describe('toggleAllRowsSelected', () => {
+    it('should respect enableRowSelection when selecting all rows', () => {
+      const data = makeData(5)
+      const columns = generateColumns(data)
+
+      let rowSelection: Record<string, boolean> = {}
+
+      const table = createTable<Person>({
+        enableRowSelection: row => row.index !== 2, // Row at index 2 cannot be selected
+        onStateChange: updater => {
+          const newState =
+            typeof updater === 'function' ? updater(table.getState()) : updater
+          rowSelection = newState.rowSelection
+        },
+        renderFallbackValue: '',
+        data,
+        get state() {
+          return { rowSelection }
+        },
+        columns,
+        getCoreRowModel: getCoreRowModel(),
+      })
+
+      table.toggleAllRowsSelected(true)
+
+      expect(rowSelection['0']).toBe(true)
+      expect(rowSelection['1']).toBe(true)
+      expect(rowSelection['2']).toBeUndefined() // Row 2 should not be selected
+      expect(rowSelection['3']).toBe(true)
+      expect(rowSelection['4']).toBe(true)
+    })
+
+    it('should respect enableRowSelection when deselecting all rows', () => {
+      const data = makeData(5)
+      const columns = generateColumns(data)
+
+      let rowSelection: Record<string, boolean> = {
+        '0': true,
+        '1': true,
+        '2': true, // This row was somehow selected (maybe rules changed)
+        '3': true,
+        '4': true,
+      }
+
+      const table = createTable<Person>({
+        enableRowSelection: row => row.index !== 2, // Row at index 2 cannot be selected
+        onStateChange: updater => {
+          const newState =
+            typeof updater === 'function' ? updater(table.getState()) : updater
+          rowSelection = newState.rowSelection
+        },
+        renderFallbackValue: '',
+        data,
+        get state() {
+          return { rowSelection }
+        },
+        columns,
+        getCoreRowModel: getCoreRowModel(),
+      })
+
+      table.toggleAllRowsSelected(false)
+
+      expect(rowSelection['0']).toBeUndefined()
+      expect(rowSelection['1']).toBeUndefined()
+      expect(rowSelection['2']).toBe(true) // Row 2 should remain selected since it can't be deselected
+      expect(rowSelection['3']).toBeUndefined()
+      expect(rowSelection['4']).toBeUndefined()
+    })
+  })
 })

From 5fffb9ab7f601a4c2014ec8ec7b91810dd00f1e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tr=E1=BA=A7n=20Trung=20Ki=C3=AAn?= <poverty1990@gmail.com>
Date: Thu, 27 Nov 2025 17:27:56 +0700
Subject: [PATCH 2/2] add changeset

---
 .changeset/eleven-dingos-drum.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/eleven-dingos-drum.md

diff --git a/.changeset/eleven-dingos-drum.md b/.changeset/eleven-dingos-drum.md
new file mode 100644
index 0000000000..40323d3633
--- /dev/null
+++ b/.changeset/eleven-dingos-drum.md
@@ -0,0 +1,5 @@
+---
+'@tanstack/table-core': patch
+---
+
+fix: toggleAllRowsSelected to respect row selection rules