From 781a25047b2e54c85e0de004d1655a55b07bcc1e Mon Sep 17 00:00:00 2001 From: James Bruten Date: Fri, 5 Dec 2025 09:51:14 +0000 Subject: [PATCH 1/2] add default group --- github_scripts/suite_data.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/github_scripts/suite_data.py b/github_scripts/suite_data.py index 9cae85bd..91fc21f5 100644 --- a/github_scripts/suite_data.py +++ b/github_scripts/suite_data.py @@ -341,6 +341,8 @@ def read_groups_run(self) -> str: if row[0] in ("g", "group"): groups = row[1].strip("[]'\"").split(",") break + if groups is None: + groups = "suite_default" return groups def get_task_states(self) -> Dict[str, str]: From 6196879dc9b3450bf781f9df502504a9b7a8a89b Mon Sep 17 00:00:00 2001 From: James Bruten Date: Fri, 5 Dec 2025 09:53:36 +0000 Subject: [PATCH 2/2] change type and hinting --- github_scripts/suite_data.py | 4 ++-- github_scripts/suite_report_git.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/github_scripts/suite_data.py b/github_scripts/suite_data.py index 91fc21f5..140653b5 100644 --- a/github_scripts/suite_data.py +++ b/github_scripts/suite_data.py @@ -329,7 +329,7 @@ def get_suite_starttime(self) -> str: starttime = row[0] return starttime.split("+")[0] - def read_groups_run(self) -> str: + def read_groups_run(self) -> List[str]: """ Read in groups run as part of suite from the cylc database file """ @@ -342,7 +342,7 @@ def read_groups_run(self) -> str: groups = row[1].strip("[]'\"").split(",") break if groups is None: - groups = "suite_default" + groups = ["suite_default"] return groups def get_task_states(self) -> Dict[str, str]: diff --git a/github_scripts/suite_report_git.py b/github_scripts/suite_report_git.py index 7e77f786..bc336bb4 100755 --- a/github_scripts/suite_report_git.py +++ b/github_scripts/suite_report_git.py @@ -74,7 +74,7 @@ def __init__(self, suite_path: Path) -> None: self.suite_starttime: str = self.get_suite_starttime() self.workflow_id: str = self.get_workflow_id() self.task_states: Dict[str, str] = self.get_task_states() - self.groups: str = self.read_groups_run() + self.groups: List[str] = self.read_groups_run() self.rose_data: Dict[str, str] = self.read_rose_conf() self.dependencies: Dict[str, Dict] = self.read_dependencies() self.primary_source: str = self.determine_primary_source()