Add 3.14 testing to CI and fix one 3.14 issue#1338
Closed
braingram wants to merge 2 commits intoGalSim-developers:mainfrom
Closed
Add 3.14 testing to CI and fix one 3.14 issue#1338braingram wants to merge 2 commits intoGalSim-developers:mainfrom
braingram wants to merge 2 commits intoGalSim-developers:mainfrom
Conversation
Member
|
Thanks Brett. There are some other fixes on #1335 that would be needed to get the CI to pass here. So rather than port them over, I just added the 3.14 addition to that PR. So I'm closing this one. But thanks for checking that everything works fine in 3.14. |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to successfully run the python unit tests with python 3.14. I noticed one warning:
This PR fixes the above invalid escape (#1335 also fixes the same regex in the same way) and adds 3.14 to the CI.
Is
mainthe correct branch to target for these changes?Also if this warrants a changelog entry please let me know where to add one. Thanks!