Skip to content

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Jan 20, 2026

There are quite a few files which appear to be unused (i.e. neither included nor compiled).
Please check whether any of them are used outside the repository or should be kept for other reasons.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 748fad9 at 2026-01-20 11:50:

## sw/BUILD/O2-latest/log
ninja: error: '/sw/SOURCES/O2/14973-slc9_x86-64/0/GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h', needed by 'GPU/GPUTracking/Base/hip/hipify/GPUReconstructionHIPIncludesSystem.h', missing and no known rule to make it

Full log here.

@vkucera vkucera changed the title Delete unused files [WIP] Delete unused files Jan 20, 2026
*
* FOCAL reconstruction workflow package. See \ref refFOCALworkflow
* for more information.
*/ No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the FOCAL part in O2 is under construction, I suggest to not remove anything please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recovered

@lmassacr
Copy link
Contributor

Hi @vkucera,

Some of the MID code proposed to be suppressed in this PR has been used for analyses on some tests bench. If there is no necessity to remove the code, I would prefer that we keep it. @dstocco can you confirm what needs to be kept for MID?

I am also checking for the MCH files with @aferrero2707 @pillot and other muon experts, please do not go ahead with removing code before our feedbacks.

Thanks,
Cheers,
Laure

@dstocco
Copy link
Contributor

dstocco commented Jan 20, 2026

In the past we were indeed using the MID decoded-data-dump-workflow. However, looking now at this PR, I realise that the code is not in a CMakeLists.txt, so indeed it does not seem to be compiled.
It might be a leftover from some local development branch. This being the case, contrary to what I told to Laure, it is ok to delete the proposed file for MID.

@f3sch
Copy link
Collaborator

f3sch commented Jan 20, 2026

@vkucera please remove the changes to any ITS2&3 code. In the former case, I will open a PR soon where this is anyways done, in the latter its plainly wrong that the digit reader/writer is not built, will fix soon.

@vkucera
Copy link
Collaborator Author

vkucera commented Jan 20, 2026

@vkucera please remove the changes to any ITS2&3 code. In the former case, I will open a PR soon where this is anyways done, in the latter its plainly wrong that the digit reader/writer is not built, will fix soon.

Recovered

@vkucera vkucera requested a review from sawenzel as a code owner January 21, 2026 19:51
@vkucera vkucera changed the title [WIP] Delete unused files Delete unused files Jan 21, 2026
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 3cbb2f9 at 2026-01-21 22:50:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14973-slc9_x86-64/0/GPU/GPUbenchmark/cuda/../Shared/Kernels.h:18:10: fatal error: Utils.h: No such file or directory
/sw/SOURCES/O2/14973-slc9_x86-64/0/GPU/GPUbenchmark/cuda/../Shared/Kernels.h:18:10: fatal error: Utils.h: No such file or directory
/sw/SOURCES/O2/14973-slc9_x86-64/0/GPU/GPUbenchmark/hip/../Shared/Kernels.h:18:10: fatal error: 'Utils.h' file not found
/sw/SOURCES/O2/14973-slc9_x86-64/0/GPU/GPUbenchmark/hip/../Shared/Kernels.h:18:10: fatal error: 'Utils.h' file not found
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 98c6c83 at 2026-01-22 06:08:

## sw/BUILD/O2-latest/log
CMake Error at /sw/slc9_x86-64/ROOT/v6-36-04-alice9-2/cmake/RootMacros.cmake:454 (message):

Full log here.

@davidrohr
Copy link
Collaborator

Hi @vkucera : Thx for the effort. From the GPU folder, please delete only makefile_opencl_compiler.cxx, opencl_compiler_structs.h, opencl_obtain_program.h. and GPUTPCDefinitions.h.

All the other files in the GPU folder are needed in certain build cases, or for manual QA / tests.

In general, I am not sure if we really need to do such a cleanup. Also other people / projects might have files for manual tests in here, so I would wait for feedback before merging, and I would send a mail to o2-wp-all and to the detectors, to double-check.

@ktf
Copy link
Member

ktf commented Jan 22, 2026

How about you do smaller PRs with this, targeting one or two files? It should make it easier to review / approve.

@vkucera
Copy link
Collaborator Author

vkucera commented Jan 22, 2026

Hi @vkucera : Thx for the effort. From the GPU folder, please delete only makefile_opencl_compiler.cxx, opencl_compiler_structs.h, opencl_obtain_program.h. and GPUTPCDefinitions.h.

All the other files in the GPU folder are needed in certain build cases, or for manual QA / tests.

In general, I am not sure if we really need to do such a cleanup. Also other people / projects might have files for manual tests in here, so I would wait for feedback before merging, and I would send a mail to o2-wp-all and to the detectors, to double-check.

Hi @davidrohr , thanks for checking. I will make a separate PR.

@vkucera
Copy link
Collaborator Author

vkucera commented Jan 22, 2026

How about you do smaller PRs with this, targeting one or two files? It should make it easier to review / approve.

I can split it by first-level directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

8 participants